chore: re-enable Dialog e2e #22853
Merged
chore: re-enable Dialog e2e #22853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-fluent-ui-bot
added
the
Fluent UI react-northstar (v0)
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 986162e:
|
Collaborator
📊 Bundle size report🤖 This report was generated against e465622ca241f3dd0534da50823a51e7311fd9ef |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e465622ca241f3dd0534da50823a51e7311fd9ef (build) |
ling1726
approved these changes
May 5, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* check mouse down * e2e fix * revert dialog change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables Dialog cypress test.
It's disabled previously by #17483 due to flakyness. #22544 introduced cypress retry, so this PR re-enables the tests.
A small change was made to test as it was failing: Dialog dropdown list is considered not 'visible' by cypress because it was partially covered in the test. But the tests are for keyboarding, so it only needs to verify dropdown list exist.